Differences
This shows you the differences between two versions of the page.
| Both sides previous revision Previous revision Next revision | Previous revision | ||
|
soc:2010:cooldavid:journal:week9 [2010/07/26 05:43] cooldavid |
soc:2010:cooldavid:journal:week9 [2010/07/29 07:08] (current) cooldavid |
||
|---|---|---|---|
| Line 20: | Line 20: | ||
| * We can now safely modify the heap_size as we want. :) | * We can now safely modify the heap_size as we want. :) | ||
| - | === Michael's reply of my recent patchset === | + | ==== Michael's reply of my recent patchset ==== |
| <file> | <file> | ||
| Thank you for your TCP patches, some of which I have applied directly to iPXE, | Thank you for your TCP patches, some of which I have applied directly to iPXE, | ||
| Line 100: | Line 100: | ||
| Michael | Michael | ||
| + | </file> | ||
| + | |||
| + | <file> | ||
| + | Yes! And I think it is be better than what I did in | ||
| + | "[tcp] Receive and Close flow adjustment". to put xfer_deliver_iob() | ||
| + | in tcp_process_rx_queue() seems more reasonable. | ||
| + | |||
| + | I would be honored to put together a patch of the passive close | ||
| + | facility and the above you suggested on top of current iPXE TCP stack. | ||
| + | |||
| + | BTW, do you think it's reasonable to do something like: | ||
| + | "[tcp] Cleanup TCP closing actions" patch which it sumbitted | ||
| + | on gpxe-devel list?[2] | ||
| + | |||
| + | I think it might be useful for following reasons: | ||
| + | 1. We don't have to think of what would tcp_close() do if we call it | ||
| + | somewhere. The behavior of calling tcp_close() would be always the same. | ||
| + | 2. Reduced some duplicate code. | ||
| + | 3. We don't have to separate tcp_close() from tcp_rx_fin(). And have the same | ||
| + | behavior. Seems a little more neat to me. | ||
| + | |||
| + | Above results are accomplished by: | ||
| + | 1. Separate terminate action. | ||
| + | 2. Separate terminate action. | ||
| + | 3. Separate nullify xfer interface. | ||
| + | (Which is part of "[tcp] Receive and Close flow adjustment"[1]) | ||
| + | |||
| + | [1]: | ||
| + | http://git.etherboot.org/?p=people/cooldavid/gpxe.git;a=commitdiff;h=8fc73d18c8528cbcc1b1c3849b51d3ee3682c937 | ||
| + | [2]: | ||
| + | http://git.etherboot.org/?p=people/cooldavid/gpxe.git;a=commitdiff;h=660e96200f67c981e7397eb05fbb4e91ed253f50 | ||
| + | |||
| + | Guo-Fu Tseng | ||
| </file> | </file> | ||
