[gPXE] [PATCH] [pciextra] Restore the PCI COMMAND register after writing to the BARs

[Marty Connor]

On 1/29/10 8:39 AM, Marty Connor wrote:
> On 1/22/10 10:25 AM, Bernhard Kohl wrote:
>> By the way, I saw that my patch was already applied on the master 
>> branch. There is some disordering of the comment lines. The line /* Find 
>> the significant bits */ must go 2 lines lower.
>> Thank You
>> Bernhard
> 
> Hi Bernhard,
> 
> I rewrote the pci_bar_size function for clarity and to make clear that
> we (gPXE developers) are not convinced that the saving of the
> PCI_COMMAND word is needed.
> 
> Our larger concern is that we are masking a KVM PCI bug here, and we
> would prefer not to add this work-around to our code if we can avoid it.
>  As far as I can tell, the saving and restoring of that word is a NOOP.
> 
> Please test the attached patch and let us know if it works.
> 
> Thanks for your help with this,
> 
> / Marty /

I messed up the first patch.  Please try the attached one instead.

Thanks,

/ Marty /


-------------- next part --------------
A non-text attachment was scrubbed...
Name: pci_bar_size.patch
Type: text/x-patch
Size: 2668 bytes
Desc: not available
Url : http://etherboot.org/pipermail/gpxe/attachments/20100129/fc94ffcb/attachment.bin