[gPXE] [PATCH] [natsemi] Convert stray mmio readl() to pio inl()

Stefan Hajnoczi stefanha at gmail.com
Mon Jan 25 04:17:47 EST 2010


This driver uses programmed I/O to access hardware registers.  There is
a stray memory-mapped I/O read on a programmed I/O address.  Perhaps
this is an artifact of porting the driver.  Fix this by converting it to
programmed I/O.

Signed-off-by: Stefan Hajnoczi <stefanha at gmail.com>
---
 src/drivers/net/natsemi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/drivers/net/natsemi.c b/src/drivers/net/natsemi.c
index 8ca6271..db3f320 100644
--- a/src/drivers/net/natsemi.c
+++ b/src/drivers/net/natsemi.c
@@ -270,7 +270,7 @@ static void natsemi_reset (struct net_device *netdev)
         wcsr = inl (np->ioaddr + WOLCmd) & WCSR_RESET_SAVE;

         /* RFCR */
-        rfcr = readl (np->ioaddr + RxFilterAddr) & RFCR_RESET_SAVE;
+        rfcr = inl (np->ioaddr + RxFilterAddr) & RFCR_RESET_SAVE;

         /* PMATCH */
         for (i = 0; i < 3; i++) {
-- 
1.6.5


More information about the gPXE mailing list