[PATCH] [rtl818x] Remove broken mmio register support

Stefan Hajnoczi stefanha at gmail.com
Fri Jan 22 13:12:48 EST 2010


The rtl818x driver uses programmed I/O but has a fallback to
memory-mapped I/O registers.  The fallback currently will not work since
the registers are accessed using inl()/outl() programmed I/O functions
in the driver.  This patch removes the fallback to we fail cleanly when
programmed I/O is not possible.

Signed-off-by: Stefan Hajnoczi <stefanha at gmail.com>
---
 src/drivers/net/rtl818x/rtl818x.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/src/drivers/net/rtl818x/rtl818x.c
b/src/drivers/net/rtl818x/rtl818x.c
index 167409d..7c7ca48 100644
--- a/src/drivers/net/rtl818x/rtl818x.c
+++ b/src/drivers/net/rtl818x/rtl818x.c
@@ -680,9 +680,6 @@ static int rtl818x_probe(struct pci_device *pdev,
 	dev->netdev->dev = &pdev->dev;

 	priv->map = (struct rtl818x_csr *)pdev->ioaddr;
-	if (!priv->map)
-		priv->map = (struct rtl818x_csr *)pdev->membase;
-
 	if (!priv->map) {
 		DBG("rtl818x: cannot find device memory\n");
 		err = -ENXIO;
-- 
1.6.5


More information about the gPXE mailing list