[gPXE] [Etherboot-developers] [PATCH] [myri10ge] new native gPXE driver.

[Glenn Brown]

Stefan Hajnoczi wrote:
> Looks good.  It's nice to see high-end hardware that can be driven in
> a clean and simple way.
>   
Thanks.  The OS-drivers are not so clean and simple, thanks to LRO, RSS, 
TSO, MSI, NAPI, thread safety, virtualization, etc.  It felt great to 
leave that complexity out.
> My only suggestion is that myri10ge_net_close() should not error
> outstanding TX.  The net device core code already does this in
> net/netdevice.c:netdev_tx_flush().  This function is called right
> after the driver's close() returns in net/netdevice.c:netdev_close().
>   
Great catch!

Do you mind if I slip in a couple trivial cleanups into my revised 
patch?  Proposed changes are
attached.  If they are OK with you I will generate a myri10ge_v2.patch 
after retesting.

Thanks,
--Glenn
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: myri10ge_delta.patch
Url: http://etherboot.org/pipermail/gpxe/attachments/20100105/52413017/attachment.cc