[gPXE] [PATCH] Disable sky2 interrupts until explicitly enabled

Daniel Verkamp daniel at drv.nu
Fri Feb 26 18:05:34 EST 2010


On Fri, Feb 26, 2010 at 5:02 PM, Daniel Verkamp <daniel at drv.nu> wrote:
> This fixes lockups encountered on normal PC hardware where
> EFI is not used: STI in real-mode code triggered the hang.
>
> This changes probe and open so that all sky2 interrupts are
> disabled until sky2_net_irq() is called explicitly.
> ---

Thanks to stefanha for assisting in the debugging of this problem; he
suggested the idea behind this patch.  Any comments on how this could
be done better are appreciated.  The patch does work at least on my
test system, but I have not exercised the driver with UNDI, so the
_irq code has not been tested.

A better commit message probably could be written as well, perhaps by
someone who understands the problem better.

Thanks,
-- Daniel Verkamp


More information about the gPXE mailing list