[gPXE-devel] [iscsi] base64 support for CHAP revisited

[Joshua Oreman]

2010/5/28 Piotr Jaroszyński <p.jaroszynski at gmail.com>:
>>> Micheal's implementation of decoding [1] takes 196 bytes, so we could
>>> also use that. My patch for adding base64 support to iscsi should
>>> mostly work as is, but seeing that Michael didn't apply it (yet?) we
>>> might want to wait and see :)
>>
>> https://git.ipxe.org/ipxe.git/commitdiff/8a16fd05dc6c3c97d071eb331c6a381d17344dec
>>
>> (Tested against a base16-using iSCSI target; testing against a base64-using
>> target welcome.)
>
> Thank you. I have tested that against a starwind server which uses
> base64 encoding and it works fine.
>
>
> I have prepared a branch that can be merged into gpxe based on ipxe changes:
>
> http://git.etherboot.org/?p=people/peper/gpxe.git;a=shortlog;h=refs/heads/base64-ipxe
>
> Note that I have squashed "[iscsi] Use generic base16 functions for
> iSCSI reverse CHAP" into        "[iscsi] Use generic base16 functions for
> iSCSI". Can unsquash if that's clearer.

Merged: http://git.etherboot.org/?p=gpxe.git;a=summary

I did the merge by just resetting master to the tip of your prepared
branch, which made you show up as the committer. Apologies for the
mixup.

-- Josh