[gPXE-devel] [PATCH] Re-enable management mode checks on e1000e

[Joshua Oreman]

On Thu, May 27, 2010 at 4:29 PM, Geoff Lywood <glywood at vmware.com> wrote:
> Currently the e1000e driver will crash when the 80003es2lan code attempts to
> call hw->mac.ops.check_mng_mode(), because that function pointer is never
> initialized. This patch makes sure that check_mng_mode is set for every type
> of PHY.
>
> I am open to suggestions for other ways to solve this problem. I do not
> really understand why the management mode checks were commented out in the
> first place.

Adding Marty on CC, as he's the one who ported the driver. I suspect
this was simply a case of overzealous feature removal (as most of the
e1000e's features are unnecessary in gPXE); might it be possible
instead to remove the need to check for management mode?

-- Josh