[gPXE-devel] [iscsi] base64 support for CHAP
Piotr Jaroszyński
p.jaroszynski at gmail.com
Fri Mar 26 23:35:21 EDT 2010
Hello,
following is my attempt at implementing base64 support for CHAP.
I have included two implementations for base64 decoding, but the one with
transition table is faster, cleaner (at least imho :) and also recently got
smaller than the if-else one (it was bigger at first and that's why I am
considering it at all). But I guess that the size impact of both approaches
can change after your comments. I am not too happy about how '=' is handled,
but don't have a better idea now (note that it's also not checked for
misplacement).
Changes in iscsi are rather straightforward, but have a bit bigger size impact
than I expected.
I have tested mutual chap auth with both a starwind server for base64 and ietd
for hex. Also windows 7 installer/boot successfully takes over the iscsi
connection.
base64 +304
iscsi +53
TOTAL: +357
[PATCH 1/2] [base64] Add decoding support.
[PATCH 2/2] [iscsi] Add base64 support for CHAP.
--
Best Regards
Piotr Jaroszyński
More information about the gPXE-devel
mailing list