[gPXE-devel] [PATCH] [pcnet32] Replace pcnet32 driver

[Stefan Hajnoczi]

On Wed, Jun 16, 2010 at 4:14 PM, Joshua Oreman <oremanj at rwcr.net> wrote:
> On Wed, Jun 16, 2010 at 1:29 AM, Stefan Hajnoczi <stefanha at gmail.com> wrote:
>> pcnet32.c:pcnet32_setup_mac_addr:
>>        for ( i = 0; i < ETH_ALEN; i++ )
>>                promaddr[i] = inb ( ioaddr + i );
>> This can be replaced with:
>>        insb ( ioaddr, promaddr, ETH_ALEN );
>
> I'm pretty sure this is incorrect; insb() loads N bytes in sequence
> from the same I/O port.

You're right, thanks for catching that.  I don't think we have a
helper function to do this then.

Stefan