[gPXE-devel] [PATCH] [compiler] Mark weak functions noinline

[Stefan Hajnoczi]

On Wed, Jul 14, 2010 at 10:13 AM, Stefan Hajnoczi <stefanha at gmail.com> wrote:
> Weak functions whose visibility is hidden may be inlined due to a bug in
> GCC.  Explicitly mark weak functions noinline to work around the
> problem.
>
> This makes the PXE_MENU config option work again, the PXE boot menu was
> never being called because the compiler inlined a weak stub function.
>
> The GCC bug was identified and fixed by Richard Sandiford
> <rdsandiford at googlemail.com> but in the meantime gPXE needs to implement
> a workaround.
>
> Reported-by: Steve Jones <steve at squaregoldfish.co.uk>
> Reported-by: Shao Miller <shao.miller at yrdsb.edu.on.ca>
> Suggested-by: Joshua Oreman <oremanj at rwcr.net>
> Signed-off-by: Stefan Hajnoczi <stefanha at gmail.com>
> ---

Applied.

http://git.etherboot.org/?p=gpxe.git;a=commitdiff;h=1a260f8098d01caab029564005dfc132b0dce1ff

Stefan