[gPXE-devel] [PATCH] Rom-O-Matic: Convert short tags to long tags

Marty Connor mdc at etherboot.org
Fri Aug 6 06:45:38 EDT 2010


Hi Brandon,

Thanks for the patch!  It looks fine to me, and I'll likely apply
it soon.

For future reference, it is helpful if you also paste your patch
inline in your message (as well as attaching it as a text attachment),
because it makes it easier for some developers to hit "reply" and
comment on the code.

That's just a detail, and it's very nice of you to take the time
to debug, test, send a patch, and add a support task.

Thanks and Best Regards,

/ Marty /

On 8/5/10 11:17 PM, Brandon Penglase wrote:
> Coming up for PHP6, short tags are being deprecated.
> 
> I noticed on my web server when trying to use Rom-O-Matic, that it was
> not loading properly. It seems that right now, at least with a default
> Gentoo install, PHP5 has Short Tags turned off. So I created the
> following patch to convert the short tags to long tags.
> 
> The testing I have done has not showed any changes in operation.
> 
> This is my first patch using GIT, so let me know if I ended up doing
> something wrong.
> 
> If the patch does not come through on the Mailing List, here is a web
> link for it:
> http://smart-serv.net/~brandon/gpxe-romomatic-convert-shorttags.patch



More information about the gPXE-devel mailing list