[gPXE-devel] [PATCH] [sky2] Disable interrupts by default

[Joshua Oreman]

On Mon, Aug 2, 2010 at 8:39 AM, Gilles Martin <gilles.martin at psi.ch> wrote:
> Le vendredi 30 juillet 2010 à 20:39 +0100, Stefan Hajnoczi a écrit :
>> On Thu, Jul 29, 2010 at 8:00 PM, Joshua Oreman <oremanj at rwcr.net> wrote:
>> > On Thu, Jul 29, 2010 at 11:56 AM, Stefan Hajnoczi <stefanha at gmail.com> wrote:
>> >> Device interrupts should be disabled by default in the sky2 driver.
>> >> They are explicitly enabled when a PXE NBP client program uses the UNDI
>> >> interface, which is designed around interrupts.  Having interrupts
>> >> enabled when no handler is installed to service them results in hangs
>> >> because the spurious interrupt is never reset and remains high.
>> >
>> > Looks good to me. Thanks, Stefan!
>> >
>> > Feel free to push after 24 hours.
>> >
>> > -- Josh
>>
>> Thanks the the review Josh.
>>
>> Gilles: I'd be thankful if you're able to run two tests with the patch applied:
>
> Yes sure. I just have a little problem is that I don't have access to
> Git from my place (Blocked by firewall). Is there a way to patch the
> sky2.c file without using Git (I'm not really used to patch...)? Or I
> just need a link with the GPXE patched version of sky2.c.

You can download a source snapshot (.tar.gz) from the gitweb
repository: http://git.etherboot.org/?p=gpxe.git;a=snapshot;h=fa91c2c3269554df855107a24afec9a1149fee8f;sf=tgz

Pipe Stefan's original email to `patch -p1' in the top-level gpxe/
directory to apply the patch.

-- Josh