[gPXE-devel] [PATCH] [dhcp] Allow multiple interfaces in dhcp command

[Stefan Hajnoczi]

On Sat, Jul 31, 2010 at 4:43 PM, Lars Kellogg-Stedman <lars at oddbit.com> wrote:
>> Looks good.  I would like to merge this commit.
>>
>> Lars, can you please provide your Signed-off-by line (i.e. Signed-off-by: Lars
>> Kellogg-Stedman <lars at oddbit.com>)?
>
> Sure.  I've added it to the text of your message; let me know if this
> isn't the right procedure:
>
> From: Lars Kellogg-Stedman <lars at oddbit.com>
>
> The "dhcp" command now accepts a list of interfaces and to try until one
> succeeds:
>
>  gPXE> dhcp net0 net1 net2
>
> If an interface does not exist a message is printed and it is skipped.
>
> If given the single parameter "any" as an interface name, all interfaces
> are tried in a manner similar to autoboot:
>
>  gPXE> dhcp any
>  DHCP (net0 xx:xx:xx:xx:xx:xx)........ Connection timed out (...)
>  Could not configure net0: Connection timed out (...)
>  DHCP (net1 xx:xx:xx:xx:xx:xx).... ok
>  gPXE>
>
> Note that interfaces which fail to DHCP are closed.  This is usually
> desirable since an open interface consumes memory.  On machines with
> several interfaces it is possible to exhaust the heap if all interfaces
> are open simultaneously.  This behavior differs from the previous "dhcp"
> command implementation but should not be detectable to user scripts
> since they abort when the dhcp command exits with an error.
>
> Signed-off-by: Stefan Hajnoczi <stefanha at gmail.com>
> Signed-off-by: Lars Kellogg-Stedman <lars at oddbit.com>
> ---
>
>  src/hci/commands/dhcp_cmd.c |   99 +++++++++++++++++++++++++++++++++----------
>  1 files changed, 77 insertions(+), 22 deletions(-)

Applied, thanks!

http://git.etherboot.org/?p=gpxe.git;a=commitdiff;h=fa91c2c3269554df855107a24afec9a1149fee8f

Stefan