[gPXE-devel] [PATCH v2] Some gpxe code issues identified by strictcompiler settings

[Marty Connor]

Bruce Rogers wrote on 4/12/10 11:13 AM:
>   >>>  On 4/10/2010 at 09:10 AM, Shao Miller<Shao.Miller at yrdsb.edu.on.ca>  wrote:
>> Good day Bruce,
>>
>> In regards to the patch you provided for three NIC drivers:
>>
>> Could you possibly attach the patch to an e-mail?  I'd like to track
>> your submission in the support.etherboot.org tracking system (unless
>> you'd enjoy joining and tracking it yourself).  I'd like to attach the
>> patch to the task created there.
>>
>> Also, for your ns83820 and tulip patches, I notice that ns->cur_rx is no
>> longer incremented...  I just wanted to confirm that you believe this is
>> the right thing to do.
>>
>> Thank you for your time,
>>
>> - Shao Miller
>
> Shao,
>
> Attached.
> The increment happens with the "+ 1". The code was just a classic mistake, relying upon undefined compiler behavior.
>
> Bruce

Thanks, applied:

 
http://git.etherboot.org/?p=gpxe.git;a=commit;h=f7c5918b179be57fc7f352cb33664eb43de02c30

/ Marty /