[gPXE-devel] [PATCH v2] Some gpxe code issues identified by strictcompiler settings

[Bruce Rogers]

 >>> On 4/10/2010 at 09:10 AM, Shao Miller <Shao.Miller at yrdsb.edu.on.ca> wrote: 
> Good day Bruce,
> 
> In regards to the patch you provided for three NIC drivers:
> 
> Could you possibly attach the patch to an e-mail?  I'd like to track 
> your submission in the support.etherboot.org tracking system (unless 
> you'd enjoy joining and tracking it yourself).  I'd like to attach the 
> patch to the task created there.
> 
> Also, for your ns83820 and tulip patches, I notice that ns->cur_rx is no 
> longer incremented...  I just wanted to confirm that you believe this is 
> the right thing to do.
> 
> Thank you for your time,
> 
> - Shao Miller

Shao,

Attached.
The increment happens with the "+ 1". The code was just a classic mistake, relying upon undefined compiler behavior.

Bruce

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: gpxe-code-cleanups.patch
Url: http://etherboot.org/pipermail/gpxe-devel/attachments/20100412/41ea3f2b/attachment.cc